Check out this new PyWallet fork with Python 3 and better recovery features

7 replies 235 views
keyMember
Posts: 20 · Reputation: 215
#1Jul 29, 2020, 08:51 PM
So here's the deal: I was having a tough time with PyWallet. Every time I tried to use it, the thing would crash while fetching keys from this really messed up legacy wallet.dat file. Since I run a software company, I decided to get one of my devs to take a look at PyWallet. I kinda paid him to make it better, and it turned into a new fork that supports Python 3 and has way better recovery tools for corrupted wallets. You can grab it here: https://github.com/Great-Software-Company/pywallet Also put together a simple site for it: https://pywallet.org/ Hope you find it useful! Appreciate any feedback!
6 Reply Quote Share
blockhub968Full Member
Posts: 978 · Reputation: 317
#2Jul 29, 2020, 09:21 PM
I didn't try it. But after reading the README, it seems your developer worked on it. Anyway, you may want to specify license of your pywallet. I stated this because it currently have no license[1]. At a glance, it looks good. But on "Other Open Source Bitcoin Wallet Recovery Tools" section, do you mind adding BTCRecover forked by 3rdIteration[1]? It's fork of BTCRecover with more feature, documentation and optional paid support/request. [1] https://choosealicense.com/no-permission/ [2] https://github.com/3rdIteration/btcrecover][url]https://github.com/3rdIteration/btcrecover[/url]
4 Reply Quote Share
keyMember
Posts: 20 · Reputation: 215
#3Jul 30, 2020, 03:06 AM
I'm afraid I wasn't able to find the license information of PyWallet, so I didn't add any license to my fork either. I'd use the same license, but since I couldn't find this information, I didn't want to add anything. Very nice! I added this.
2 Reply Quote Share
blockhub968Full Member
Posts: 978 · Reputation: 317
#4Jul 31, 2020, 05:18 AM
Fair point. jackjack-jj fork doesn't mention any license, while joric original works only briefly mention public domain. It makes choosing appropriate license is tricky. Source: https://github.com/joric/pywallet/blob/master/pywallet.py#L3-L6
1 Reply Quote Share
Posts: 244 · Reputation: 60
#5Aug 2, 2020, 05:05 PM
There is actually very little information on the subject of licensing with pywallet, but from what I've seen, Joric created pywallet and then Jackjack made a fork of it, although apparently Joric's original license according to his repository on Google is BSD. https://code.google.com/archive/p/pywallet/
0 Reply Quote Share
keyMember
Posts: 20 · Reputation: 215
#6Aug 2, 2020, 08:11 PM
To be perfectly honest with you, I don't have much experience in open source development and this was actually my very first fork of an existing code ever. So, I don't really know what is the correct procedure here. Should I just assume the license is BSD and therefore mark my fork as BSD license as well on Github? On a relating note: I have been working more with my updated PyWallet. I found another corrupted wallet.dat file which could not be processed by any previous versions of PyWallet, so I made improvements to my fork and it is now able to handle that type of file corruption as well and recover data from it. Debug logging was also improved.
4 Reply Quote Share
blockhub968Full Member
Posts: 978 · Reputation: 317
#7Aug 2, 2020, 09:30 PM
I managed to download the code, despite most function on that link is broken. But comparing "pywallet.py" file from that link and "pywallet.py" from Joric first commit on GitHub[1], it looks very different. It makes me think that it's mere coincidence both of them have same name. In practice, i see many project forget to choose a license or choose non-conflicting license. So if you're not sure, i would recommend you to just acknowledge original creator/previous author. [1] https://github.com/joric/pywallet/commit/bc1d07d669bf84272bc27c9f642b0aee2c53c04d
2 Reply Quote Share
Posts: 111 · Reputation: 22
#8Aug 2, 2020, 11:12 PM
OP  add detect if fake wallet - without private keys at adresses with ballance etc
4 Reply Quote Share
?Reply
Sign in to reply to this topic

Related topics